Repository navigation
chore(deps): upgrade Vite+ to 1.7.0 - #4758
james-elicx wants to merge 2 commits into
Conversation
Vite+ 1.7.0 runs type-aware linting and type checking with tsrs (the Rust port of TypeScript 7) instead of oxlint-tsgolint. It also brings Oxlint 1.94.0, Oxfmt 0.79.0, Vite 8.3.8 and Rolldown 1.2.19. The lint script no longer sets OXLINT_TSGOLINT_CHECKER_SCHEDULING: only tsgolint read it. Oxfmt 0.79 parenthesizes the instantiation expression in the dynamic() error boundary's extends clause.
|
/bigbonk review for issues |
@vinext/cloudflare
create-vinext-app
@vinext/types
vinext
@cloudflare/workers-response-store
commit: |
Six e2e fixtures have their own package.json outside the pnpm workspace, so `vp run vinext#build` there sees a one-package workspace. Vite+ 1.5 ran nothing and exited 0; since 1.6 an unknown package fails the run. Run the build from the repo root instead.
|
LGTM! |
|
/bigbonk review for issues |
|
LGTM! |
Performance benchmarksCompared 1 improved · 1 regressed · 5 within ±1.5%
View detailed results and traces 🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head |
|
There was a problem hiding this comment.
✅ Approved — A clean toolchain upgrade with no findings. The e2e build commands now run from the right directories, and the dependency pins are exact.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
🚀 Release: ✅ LGTM
No issues found.
🔒 Security: ✅ LGTM
No issues found. minimumReleaseAge is unchanged in the workspace config.
📖 AGENTS.md: ✅ LGTM
No issues found.
📋 Code Quality: ✅ LGTM
No issues found.
playwright.config.ts: Each subshellcddepth matches its fixture'scwd, so the relative paths that follow still resolve.package.json: Dropping the environment variable only tsgolint read is consistent with the switch to tsrs.- Catalog pins: The
pnpm-workspace.yamlpins are exact. dynamic.ts: The change is formatting only.
⚡ Performance: ✅ LGTM
No issues found.
📝 Documentation: ✅ LGTM
No issues found.
Reviewed commit: af42cbe8
Upgrades Vite+ to 1.7.0.
vp lintandvp checknow run type-aware lint rules and type checking with tsrs, the Rust port of TypeScript 7, instead of oxlint-tsgolint (announcement). The release also brings Oxlint 1.94.0, Oxfmt 0.79.0, Vite 8.3.8 and Rolldown 1.2.19.lintscript dropsOXLINT_TSGOLINT_CHECKER_SCHEDULING=sorted: only tsgolint read it, and neither Oxlint 1.94 nor tsrs does.dynamic()error boundary'sextendsclause (formatting only).minimumReleaseAgegate was bypassed for this install only (--config.minimum-release-age=0), with no workspace config change. The only locked packages younger than 24h arevite-plus@1.7.0,@voidzero-dev/vite-plus-core@8.3.8000and the@voidzero-dev/vite-plus-*platform binaries; tsrs, Oxlint, Oxfmt and everything else they pull in are older.Lint results
Same results as tsgolint on this repo.
pnpm run checkpasses: 0 lint or type errors in 1858 files.To compare the two backends I ran both through the same
vp lint(same Oxlint 1.94, same config) and switched onlyOXLINT_TSGOLINT_PATH:--report-unused-disable-directivesgives the same 61 entries on both.switch-exhaustiveness-check,restrict-template-expressionsandno-misused-promises.prefer-readonly-parameter-typeshits init.each([...] as const)callbacks are reported by tsgolint only. That rule is not enabled here.Performance
pnpm run lint, medians of 6 interleaved runs on an M-series Mac (shared machine). Peak memory is summed across the whole process tree.pnpm run checktakes 5.8-6.1s instead of 7.6-8.2s, and its peak memory drops from about 5.8 GB to 2.6 GB.tests/fixtures/app-basic, main vs this PR, alternating runs:vp build(median of 8)vp devcold start to first/200 (median of 12)Testing
pnpm run checkvp test run tests/vite-command-contract.test.ts tests/pages-router.test.ts tests/app-router-production-build.test.ts(599 passed)